Re: [PATCH/RFC] atafb and panning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Fix panning on ARAnyM (Falcon emulation). Without this, `fbtest test011' fails
(for a 320x200x8 display with virtual 640x400).

Fails how, exactly? 

It shows a corrupted display (bad line length) if xoffset & 15 != 0.

OK; this should work but I'll have to verify it in 2.4. 
 
If var->xoffset has the low order bits set (sub-word pixel offset) 
par->hw.falcon.xoffset takes care of that, and xoffset takes care of the rest. 
Since the partial word offset shifts the beginnig of the scan line into the 
first word, the offset to the next scan line (par->hw.falcon.line_offset) has to 
be shortened. 

Sounds reasonable. But the shortening part doesn't work on ARAnyM, nor do
small panning increments. So it really smells like an ARAnyM bug.

Petr said as much if I understand him right. No need to fix ARAnyM though, we 
just need to keep that in mind. 
 
I'll test your patch as soon as I get fbtest to work (missing libgcc_s.so.2).

The alternative is to compile fbtest yourself (CVS module
FBdev/utlilities/fbtest from project linux-fbdev on sf.net).

Tried that before but could not get it to work a year ago. Will retry.

I've been thinking of putting a git clone on kernel.org...

Good thinking - git I can use (sort of) :-)

	Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux