Re: [PATCH] Add install target for m68k architecture.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Le 2 nov. 08 à 10:02, Geert Uytterhoeven a écrit :

On Thu, 30 Oct 2008, Laurent@xxxxxxxxxxxx wrote:
From: Laurent Vivier <Laurent@xxxxxxxxxxxx>

This patch enables the use of "make install" on m68k architecture
to copy kernel to /boot.

Signed-off-by: Laurent Vivier <Laurent@xxxxxxxxxxxx>
---
arch/m68k/Makefile   |    3 ++
arch/m68k/install.sh | 52 ++++++++++++++++++++++++++++++++++++++++ ++++++++++

It seems like we have lots of install.sh files in arch/*/{boot/}. No two of
them are identical, but they're all very similar.
Perhaps it's better to consolidate them?

I agree, but introducing a modification touching several architectures and maintainers are harder to push into kernel.
But I'm going to try.

+# User may have a custom install script
+
+if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/$ {CROSS_COMPILE}installkernel "$@"; fi +if [ -x /sbin/${CROSS_COMPILE}installkernel ]; then exec /sbin/$ {CROSS_COMPILE}installkernel "$@"; fi

I know the original one has the same limitation, but shouldn't we check for
all ${CROSS_COMPILE}installkernel in the user's $PATH?


I've copied the original one and though having a cross-compile install kernel is a good idea, it's why I let these two lines.
Is there security issues by trying all installkernel scripts ?
Otherwise, I agree, and it's easy to to scan PATH to do that.

Regards,
Laurent
----------------------- Laurent Vivier ----------------------
"The best way to predict the future is to invent it."
- Alan Kay





--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux