Re: [PATCH] reinstate mac rtc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Sun, 26 Oct 2008, Michael Schmitz wrote:

Test and improve, please.

I think the patch won't work because the catchall is never invoked.

My bad - I thought the problem was related to a missing RTC driver on 
those Macs in question.
 
I'd use a new kernel parameter for this (if I thought we needed 
another workaround) rather than assume a working RTC by default. If 
you assume it works, you may introduce non-determinism when the clock 
battery is flat or missing. Best let userland make the call.

A new kernel parameter might be used to 'switch off' the RTC. But we 
could instead use the boot time to initialize the system clock if we 
find the RTC returns bogus data. How do we detect bogus data?

I don't think you have to attempt that. It is sufficient to test test for 
macintosh_config->ident != MAC_MODEL_IIFX in the 
macintosh_config->adb_type == MAC_ADB_IOP case (since IOP ADB implies IIfx 
or Q9x0). And do something similar for the else condition (RTC write).

Finn



	Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux