On Tue, 7 Oct 2008, Brad Boyer wrote:
I know this is secondary to the purpose of the patch, but shouldn't the free_irq inside CONFIG_ATARI in fbcon_exit have an if(MACH_IS_ATARI) conditional? Obviously that's unchanged by this patch but is visible in
Yes it should. I'll cook a patch.
the context. I think this would cause problems with a multi-machine build running on a mac, although I'm not sure if that ever really gets called for our normal situation. I don't think we ever get rid of the console. Brad Boyer flar@xxxxxxxxxxxxx @@ -3540,10 +3475,6 @@ #ifdef CONFIG_ATARI free_irq(IRQ_AUTO_4, fb_vbl_handler); #endif -#ifdef CONFIG_MAC - if (MACH_IS_MAC && vbl_detected) - free_irq(IRQ_MAC_VBL, fb_vbl_handler); -#endif kfree((void *)softback_buf); softback_buf = 0UL;
Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html