Re: [patch 1/2] m68k: Atari EtherNAT (SMC91C111) driver (updated)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 4 Sep 2008, Michael Schmitz wrote:
attached is the updated Atari EtherNAT aka SMC91C111 ethernet driver. The
driver is functional (i.e. does no longer mangle the first two bytes of a
packet).

I had to fudge with the SMC_PUSH_DATA function (the register interface appears
to be little endian but the data buffers are big endian), and decided to stick
that into the main driver instead of smc91x.h in the end.

Interrupts are still missing, the driver operates from a timer routine
instead.

Thanks, updated. But...  it doesn't seem to compile?

drivers/net/atari_91C111.c: In function 'smc_rcv':
drivers/net/atari_91C111.c:584: error: implicit declaration of function 'readsw'
drivers/net/atari_91C111.c: In function 'smc_hardware_send_pkt':
drivers/net/atari_91C111.c:729: error: implicit declaration of function 'writew_be'
drivers/net/atari_91C111.c:729: error: implicit declaration of function 'writesw'
drivers/net/atari_91C111.c: In function 'atari_ethernat_pdev_probe':
drivers/net/atari_91C111.c:2317: error: 'struct smc91x_platdata' has no member named 'irq_flags'
drivers/net/atari_91C111.c:2361: error: 'struct smc91x_platdata' has no member named 'irq_flags'
drivers/net/atari_91C111.c:2371: error: 'struct smc91x_platdata' has no member named 'irq_flags'
drivers/net/atari_91C111.c:2411: error: 'struct smc91x_platdata' has no member named 'irq_flags'
drivers/net/atari_91C111.c:2280: warning: unused variable 'pd'

This is atari_defconfig with all `new' Atari drivers enabled.

BTW, can you please run scripts/checkpatch.pl on your patches?

| total: 63 errors, 87 warnings, 2621 lines checked

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux