On Sun, 27 Jul 2008, Alan Cox wrote:
On Sun, 27 Jul 2008 01:39:52 +0200 (CEST)
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
commit b5391e29f428d11755ca2c91074c6db6f5c69d7c (gs: use tty_port) forgot to
update the m68k gs serial drivers.
No it did not. And you know that perfectly well from email discussion. I
didn't update them because I didn't know if they were still used and I
didn't have any test hardware.
Sorry, please s/forgot/deliberately forgot/.
My points are:
- b5391e29f428d11755ca2c91074c6db6f5c69d7c was a _trivial_ change for
the affected drivers, without significant risk
o trivial for the person who made the change in the first place
o trivial-after-the-fact once I had found time to dig into what
was really going on (which took orders of magnitude more time
for me than it would have taken for you to make this change in
the first place)
- If maintainers can't be bothered anymore to update all in-tree
drivers for such trivial changes, what's the advantage of being in
mainline?
- It broke bisection for all affected platforms, and had entered Linus'
tree while the problem was known
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
