Geert Uytterhoeven wrote:
This patch adds a character device driver to allow user space access to
the aranym natfeats nfstderr.
A few comments:
- Since you need only one character device, what about using a misc
character device instead?
- Shouldn't nfstderr_init_module() check for the presence of Aranym
natfeatures? Then you can probably drop the test in nfstderr_write()
the nf_get_id() could probably be moved to init_module as the ID never
changes at ARAnyM runtime.
BTW, I find it a pity you cannot simply do `echo XXX > /dev/console'
instead...
Wouldn't that print "XXX" on the screen?
petr
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html