Re: [PATCH] Balancing ioremap and iounmap in m68k/atari/hades-pci.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 4 Nov 2007, Roel Kluin wrote:
I have to say that this was not tested.
--
Balancing ioremap and iounmap

You forgot to balance the casts :-)

But probably nobody cares, as HADES depends on BROKEN since quite a
while...

---
 arch/m68k/atari/hades-pci.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/m68k/atari/hades-pci.c
+++ b/arch/m68k/atari/hades-pci.c
@@ -430,10 +430,10 @@ release_config_space:
 free_bus:
 	kfree(bus);
 iounmap_base_virt:
-	iounmap(pci_io_base_virt);
+	iounmap((void *)pci_io_base_virt);
 
 	for (i = 0; i < N_SLOTS; i++)
-		iounmap(pci_conf_base_virt[i]);
+		iounmap((void *)pci_conf_base_virt[i]);
 
 	return NULL;
 }

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux