Re: [PATCH 08/68] 0 -> NULL, for arch/m68k

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yoann Padioleau wrote:
When comparing a pointer, it's clearer to compare it to NULL than to 0.

 	stram_start = phys_to_virt(0);
-	kernel_in_stram = (stram_start == 0);
+	kernel_in_stram = (stram_start == NULL);

stram_start is more like an offset than pointer, IMHO. And 0 is a valid offset. The "==NULL" does not make much sense in this particular case. NULL is usually used when checking for an uninitialized pointer, right?

Petr

-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux