On Mon, 12 Feb 2007, Michael Schmitz wrote:
static volatile int main_running;
-static DECLARE_WORK(NCR5380_tqueue, (void (*)(void *))NCR5380_main, NULL);
+static DECLARE_WORK(NCR5380_tqueue, NCR5380_main);
static inline void queue_main(void)
{
@@ -1075,7 +1075,7 @@ static int NCR5380_queue_command(Scsi_Cm
* reenable them. This prevents reentrancy and kernel stack overflow.
*/
-static void NCR5380_main(void *bl)
+static void NCR5380_main(struct work_struct *work)
{
Scsi_Cmnd *tmp, *prev;
struct Scsi_Host *instance = first_instance;
NCR5380_main never uses it's argument, right? So this should not cause any
problem.
No, it never uses its argument. But (a) the cast in DECLARE_WORK() was no
longer correct and (b) casts are evil.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
