Hi Matthias, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Matthias-Fend/dt-bindings-leds-add-Texas-Instruments-TPS6131x-flash-LED-driver/20250318-154318 base: ffd294d346d185b70e28b1a28abe367bbfe53c04 patch link: https://lore.kernel.org/r/20250318-leds-tps6131x-v2-2-bc09c7a50b2e%40emfend.at patch subject: [PATCH v2 2/2] leds: tps6131x: add support for Texas Instruments TPS6131X flash LED driver config: openrisc-randconfig-r073-20250321 (https://download.01.org/0day-ci/archive/20250322/202503221153.G9HPVANn-lkp@xxxxxxxxx/config) compiler: or1k-linux-gcc (GCC) 11.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202503221153.G9HPVANn-lkp@xxxxxxxxx/ smatch warnings: drivers/leds/flash/leds-tps6131x.c:534 tps6131x_parse_node() warn: 'num_channels' unsigned <= 0 vim +/num_channels +534 drivers/leds/flash/leds-tps6131x.c 02e7ee00455be1 Matthias Fend 2025-03-18 512 static int tps6131x_parse_node(struct tps6131x *tps6131x) 02e7ee00455be1 Matthias Fend 2025-03-18 513 { 02e7ee00455be1 Matthias Fend 2025-03-18 514 const struct tps6131x_timer_config *timer_config; 02e7ee00455be1 Matthias Fend 2025-03-18 515 struct device *dev = tps6131x->dev; 02e7ee00455be1 Matthias Fend 2025-03-18 516 u32 channels[TPS6131X_MAX_CHANNELS]; 02e7ee00455be1 Matthias Fend 2025-03-18 517 u32 current_step_multiplier; 02e7ee00455be1 Matthias Fend 2025-03-18 518 u32 current_ua; 02e7ee00455be1 Matthias Fend 2025-03-18 519 u32 max_current_flash_ma, max_current_torch_ma; 02e7ee00455be1 Matthias Fend 2025-03-18 520 u32 num_channels; 02e7ee00455be1 Matthias Fend 2025-03-18 521 u32 timeout_us; 02e7ee00455be1 Matthias Fend 2025-03-18 522 int i; 02e7ee00455be1 Matthias Fend 2025-03-18 523 int ret; 02e7ee00455be1 Matthias Fend 2025-03-18 524 02e7ee00455be1 Matthias Fend 2025-03-18 525 tps6131x->valley_current_limit = device_property_read_bool(dev, "ti,valley-current-limit"); 02e7ee00455be1 Matthias Fend 2025-03-18 526 02e7ee00455be1 Matthias Fend 2025-03-18 527 tps6131x->led_node = fwnode_get_next_available_child_node(dev->fwnode, NULL); 02e7ee00455be1 Matthias Fend 2025-03-18 528 if (!tps6131x->led_node) { 02e7ee00455be1 Matthias Fend 2025-03-18 529 dev_err(dev, "Missing LED node\n"); 02e7ee00455be1 Matthias Fend 2025-03-18 530 return -EINVAL; 02e7ee00455be1 Matthias Fend 2025-03-18 531 } 02e7ee00455be1 Matthias Fend 2025-03-18 532 02e7ee00455be1 Matthias Fend 2025-03-18 533 num_channels = fwnode_property_count_u32(tps6131x->led_node, "led-sources"); 02e7ee00455be1 Matthias Fend 2025-03-18 @534 if (num_channels <= 0) { num_channels needs to be signed. 02e7ee00455be1 Matthias Fend 2025-03-18 535 dev_err(dev, "Failed to read led-sources property\n"); 02e7ee00455be1 Matthias Fend 2025-03-18 536 return -EINVAL; 02e7ee00455be1 Matthias Fend 2025-03-18 537 } 02e7ee00455be1 Matthias Fend 2025-03-18 538 02e7ee00455be1 Matthias Fend 2025-03-18 539 if (num_channels > TPS6131X_MAX_CHANNELS) { 02e7ee00455be1 Matthias Fend 2025-03-18 540 dev_err(dev, "led-sources count %u exceeds maximum channel count %u\n", 02e7ee00455be1 Matthias Fend 2025-03-18 541 num_channels, TPS6131X_MAX_CHANNELS); 02e7ee00455be1 Matthias Fend 2025-03-18 542 return -EINVAL; 02e7ee00455be1 Matthias Fend 2025-03-18 543 } 02e7ee00455be1 Matthias Fend 2025-03-18 544 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
