On Tue, Mar 11, 2025 at 09:54:02AM +0000, Jonathan Cameron wrote:
> On Mon, 10 Mar 2025 16:54:53 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
...
> > static int ncp5623_probe(struct i2c_client *client)
> > struct device *dev = &client->dev;
> > struct fwnode_handle *mc_node, *led_node;
> > struct led_init_data init_data = { };
> > - int num_subleds = 0;
> > struct ncp5623 *ncp;
> > struct mc_subled *subled_info;
> > + unsigned int num_subleds;
> I have no idea what the scheme is for ordering here. My gut
> feeling would have been to leave it in original location but it's
> not something I feel strongly about.
I guess I tried to follow multiple approaches here while moving it:
1) it follows "longer line first";
2) it follows "group the variables of the same type".
I also dunno what was behind the original code, but I think my approach has
a benefit as pointed out above.
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Thank you!
> > u32 color_index;
> > u32 reg;
> > int ret;
--
With Best Regards,
Andy Shevchenko
