On 20/02/2025 19:15, Nam Tran wrote: > This documentation ensures proper integration of the LP5812 > in Device Tree-based systems. Thank you for your patch. There is something to discuss/improve. Describe the hardware, not that DT is DT. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> > > Signed-off-by: Nam Tran <trannamatk@xxxxxxxxx> > --- > .../devicetree/bindings/leds/leds-lp5812.yaml | 34 +++++++++++++++++++ Filename based on compatible. More review when you test it. Best regards, Krzysztof
