On Sat, 14 Dec 2024, FUKAUMI Naoki wrote: > Hi Lee, > > On 12/14/24 01:35, Lee Jones wrote: > > On Fri, 13 Dec 2024, FUKAUMI Naoki wrote: > > > > > Hi, > > > > > > On 12/13/24 04:04, Lee Jones wrote: > > > > On Tue, 10 Dec 2024, FUKAUMI Naoki wrote: > > > > > > > > > Hi, > > > > > > > > > > Could you help me(write good commit message), anyone? > > > > > > > > Surely you know what the changes you authored do and why you authored > > > > them? Write out a nice description in your first language then use > > > > a free online translation tool to convert it into English. It doesn't > > > > have to be a novel. Just describe what you're doing and why it's > > > > needed. > > > > > > I have no knowledge about electrical circuits... > > > > You must know why you made this change? > > I noticed strange behavior on Radxa E25 which have pwm-multicolor. > > I compared leds-pwm.c:led_pwm_set() and > leds-pwm-multicolor.c:led_pwm_mc_set(), and found difference. > > Do the same fixed the problem, so I just thought this is correct fix. > No knowledge was required. > > Btw, this is enough for me. > > https://lore.kernel.org/linux-leds/d7d930bc-4c82-4272-b2c6-88f7cac5a3e1@xxxxxxxxxxxxx/T/#t > > Please ignore my patch. Thank you very much for your help, and sorry for > wasting your time. You didn't waste my time. If you see any other issues, please feel free to submit them. -- Lee Jones [李琼斯]
