Enable leds-group-multicolor as panic-indicator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Building off of the leds-group-multicolor driver it may be useful for some platforms (such as Siemens' IOT2050) to use such an LED grouping as a panic-indicator LED.

Currently the main blocker for this is that leds-group-multicolor implements .brightness_set_blocking(), which cannot be used in the panic path. From my current understanding there is nothing stopping converting the current implementation of the callback into .brightness_set(), since it already calls the non-blocking led_set_brightness().

However, looking into the similar driver leds-pwm-multicolor on which leds-group-multicolor seems to be based there is a mutex on its callback, which raises the question if this mutex is also needed on group-multicolor (which would impede the callback conversion) and, if so, what does it guard against?

Thank you for your help!

Diogo




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux