On Fri, 20 Sep 2024 23:59:03 +0200, Linus Walleij wrote: > The BCM63138 family of serial LED controllers has a register > where we can set up bits for the shift registers. These are > the number of rounds the bits need to be shifted before all > bits have been shifted through the external shift registers. > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml: properties:brcm,serial-shift-bits: '$ref' should not be valid under {'const': '$ref'} hint: Standard unit suffix properties don't need a type $ref from schema $id: http://devicetree.org/meta-schemas/core.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-bcm63138.example.dtb: leds@ff800800: brcm,serial-shift-bits: 16 is not of type 'array' from schema $id: http://devicetree.org/schemas/leds/leds-bcm63138.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-bcm63138.example.dtb: leds@ff800800: brcm,serial-shift-bits: 16 is not of type 'array' from schema $id: http://devicetree.org/schemas/property-units.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240920-bcm63138-leds-v1-1-c150871324a0@xxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.