Hello Lee, this is v3 of Turris Omnia LED driver changes. v1 and v2 can be found at https://lore.kernel.org/linux-leds/20240902124104.14297-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20240903101930.16251-1-kabel@xxxxxxxxxx/ This series is for 6.12 (alternatively 6.13), but it depends on changes that have been merged to 6.11-rc3. Your for-leds-next branch is based on 6.11-rc1, so it won't apply there. Changes since v2: - added interrupts property description to device-tree binding to fix the device-tree binding check reported by Rob's bot (new patch 05/11 in this series) - dropped the patch that converted to 100 column wrapping, as suggested by Arnd - took Andy's suggestions into the patch that converts to dev_err_probe() Marek Marek Behún (11): turris-omnia-mcu-interface.h: Move command execution function to global header leds: turris-omnia: Use command execution functions from the MCU driver turris-omnia-mcu-interface.h: Add LED commands related definitions to global header leds: turris-omnia: Use global header for MCU command definitions dt-bindings: leds: cznic,turris-omnia-leds: Allow interrupts property leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver leds: turris-omnia: Use dev_err_probe() where appropriate leds: turris-omnia: Use uppercase first letter in all comments ARM: dts: turris-omnia: Add global LED brightness change interrupt .../leds/cznic,turris-omnia-leds.yaml | 8 + .../dts/marvell/armada-385-turris-omnia.dts | 1 + drivers/leds/leds-turris-omnia.c | 262 +++++++----------- .../platform/cznic/turris-omnia-mcu-base.c | 3 + drivers/platform/cznic/turris-omnia-mcu.h | 130 --------- include/linux/turris-omnia-mcu-interface.h | 148 +++++++++- 6 files changed, 258 insertions(+), 294 deletions(-) -- 2.44.2