Hello, On Fri, Jul 19, 2024 at 03:55:04PM +0300, Dzmitry Sankouski wrote: > SDM845 has "General Purpose" clocks that can be muxed to > SoC pins to clock various external devices. > Those clocks may be used as e.g. PWM sources for external peripherals. > > GPCLK can in theory have arbitrary value depending on the use case, so > the concept of frequency tables, used in rcg2 clock driver, is not > efficient, because it allows only defined frequencies. > > Introduce clk_rcg2_gp_ops, which automatically calculate clock > mnd values for arbitrary clock rate. > > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx> > --- > drivers/clk/qcom/clk-rcg.h | 1 + > drivers/clk/qcom/clk-rcg2.c | 162 ++++++++++++++++++++++++++++++++++++++++-- > drivers/clk/qcom/gcc-sdm845.c | 19 ++--- > drivers/pwm/pwm-clk.c | 5 ++ I don't understand why a change to some qcom clk implementation detail needs a change to drivers/pwm/pwm-clk.c in the same commit. I guess if the change to drivers/pwm/pwm-clk.c is needed it should better go into a separate patch with an appropriate commit log?! Best regards Uwe
Attachment:
signature.asc
Description: PGP signature
