On Mon, 9 Sep 2024 10:03:40 +0100 Lee Jones <lee@xxxxxxxxxx> wrote: > On Wed, 04 Sep 2024, Mariusz Tkaczyk wrote: > > > NPEM driver will require leds class, there is an init-order conflict. > > Make sure that LEDs initialization happens first and add comment. > > > > Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx> > > Do you have a link to this discussion? https://lore.kernel.org/linux-pci/2024061429-handiness-waggle-d87a@gregkh/ I discussed this with Lukas and Dan offline and as a result I updated Makefile instead initcall change. > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > > Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@xxxxxxxxxxxxxxx> > > --- > > drivers/Makefile | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index fe9ceb0d2288..45d1c3e630f7 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -17,6 +17,9 @@ obj-$(CONFIG_PINCTRL) += pinctrl/ > > obj-$(CONFIG_GPIOLIB) += gpio/ > > obj-y += pwm/ > > > > +# LEDs must come before PCI, it is needed by NPEM driver > > This seems very fragile. > > Isn't there a better way to describe the dependency in Kconfig etc? I don't know if it is better. What I know is (according to Greg) that maintainers are aware of possible ordering issues and not described dependencies so they are not likely to allow changing it. Mariusz
