On 2024/9/6 19:41, Guenter Roeck wrote:
> On 9/6/24 02:36, Junhao Xie wrote:
>> Photonicat PMU MCU will send status reports regularly,
>> including board temperature.
>>
>
> This is not an appropriate description.
I will change to a better description.
>
>> Signed-off-by: Junhao Xie <bigfoot@xxxxxxxxxxx>
>> ---
>> drivers/hwmon/Kconfig | 10 +++
>> drivers/hwmon/Makefile | 1 +
>> drivers/hwmon/photonicat-hwmon.c | 129 +++++++++++++++++++++++++++++++
>
> Documentation missing.
Does it need to be placed in Documentation/hwmon/photonicat-hwmon.rst?
>
>> +static int pcat_hwmon_probe(struct platform_device *pdev)
>> +{
> ...
>> + dev_info(dev, "Board Temprature: %d degress C\n", hwmon->temperature);
>> +
>
> Unacceptable (misspelled) noise.
>
>> + hwmon->hwmon = devm_hwmon_device_register_with_groups(
>> + dev, label, hwmon, pcat_pmu_temp_groups);
>> +
>
> Please use the with_info API. I am not going to review the code because
> it will need to be completely rewritten.
>
> Guenter
>
Thanks for your review, I will rewrite this driver!
Best regards,
Junhao
