On 2024/9/6 17:44, Krzysztof Kozlowski wrote:
> On 06/09/2024 11:36, Junhao Xie wrote:
>> This driver implements the shutdown function of Photonicat PMU:
>>
[...]
>>
>> +config POWER_RESET_PHOTONICAT_POWEROFF
>> + tristate "Photonicat PMU power-off driver"
>> + depends on MFD_PHOTONICAT_PMU
>
> || COMPILE_TEST, no?
I will add it
depends on MFD_PHOTONICAT_PMU || COMPILE_TEST
>
>> + help
>> + This driver supports Power off for Photonicat PMU device.
[...]
>> +
>> +static int pcat_poweroff_notify(struct notifier_block *nb, unsigned long action,
>> + void *data)
>> +{
>> + struct pcat_poweroff *poweroff =
>> + container_of(nb, struct pcat_poweroff, nb);
>> +
>> + if (action != PCAT_CMD_PMU_REQUEST_SHUTDOWN)
>> + return NOTIFY_DONE;
>> +
>> + dev_info(poweroff->dev, "PMU request host shutdown\n");
>
> Nope. Drop.
I will remove this log print.
The PMU will send a shutdown command when the power button is long pressed
or the battery is low. I added this line of log to indicate the shutdown command
initiated by the PMU so that users will not be confused by the sudden shutdown.
>
>> + orderly_poweroff(true);
>> +
>> + return NOTIFY_DONE;
> Best regards,
> Krzysztof
>
Thanks for your review, I will fix all problems in next version!
Best regards,
Junhao
