Hello, Very nice series! [...] > +static const struct npem_ops dsm_ops = { > + .get_active_indications = dsm_get_active_indications, > + .set_active_indications = dsm_set_active_indications, > + .name = "_DSM PCIe SSD Status LED Management", A small nit: extra space. Bjorn, we can mend this on the branch, if are OK with that. Krzysztof