On Thu, Aug 1, 2024 at 9:15 AM Lee Jones <lee@xxxxxxxxxx> wrote: > > Nit: Subject line descriptions start with an uppercase char in LED. > > > LED controller should be reset during initialization to avoid abnormal > > behaviors. For example, when power to SoC is recycled but power to LED > > controller is not, LED controller should not presume to be in original > > state. > > > > Signed-off-by: Jack Chen <zenghuchen@xxxxxxxxxx> > > --- > > drivers/leds/flash/leds-lm3601x.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/leds/flash/leds-lm3601x.c b/drivers/leds/flash/leds-lm3601x.c > > index 7e93c447fec5..978256310540 100644 > > --- a/drivers/leds/flash/leds-lm3601x.c > > +++ b/drivers/leds/flash/leds-lm3601x.c > > @@ -434,6 +434,10 @@ static int lm3601x_probe(struct i2c_client *client) > > return ret; > > } > > > > + ret = regmap_write(led->regmap, LM3601X_DEV_ID_REG, LM3601X_SW_RESET); > > So this controller is reset via the ID register? Yes, that is correct. The MSB of LM3601X_DEV_ID_REG. > > > + if (ret) > > + dev_warn(&client->dev, "led controller is failed to reset\n"); > > "LED controller failed to reset" > > Or > > "Failed to reset the LED controller" > > > mutex_init(&led->lock); > > > > return lm3601x_register_leds(led, fwnode); > > -- > > 2.46.0.rc1.232.g9752f9e123-goog > > > > > > -- > Lee Jones [李琼斯] Thanks so much for feedback. I will send a V2 patch with changes. Best regards Jack Chen
