Re: [PATCH v2] dt-bindings: leds: Document "netdev" trigger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 01, 2024 at 01:53:09PM +0100, Lee Jones wrote:
> On Thu, 25 Jul 2024, Andrew Lunn wrote:
> 
> > > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > > > index 8a3c2398b10ce..bf9a101e4d420 100644
> > > > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > > > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > > > @@ -113,6 +113,8 @@ properties:
> > > >              # LED indicates NAND memory activity (deprecated),
> > > >              # in new implementations use "mtd"
> > > >            - nand-disk
> > > > +            # LED indicates network activity
> > > > +          - netdev
> > > 
> > > netdev is the description of the network development ML/repo, right?
> > > 
> > > Seems like an odd name for an OS agnostic property?
> > 
> > I agree that one meaning is the network development community within
> > Linux.
> > 
> > But it also means a network device, which is OS agnostic. I don't
> > really see it be any different to a memory technology device, mtd.
> 
> MTD is an acronym.
> 
> The only dodgy one I see in there is 'kbd-capslock'.
> 
> How about, now go with me here: 'network'?

We could do, but we have to keep netdev around for backwards
compatibility. There are DT blobs using it which we cannot break.

	Andrew




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux