Hi! > The LED1202 is a 12-channel low quiescent current LED driver. > The output current can be adjusted separately for each channel by > 8-bit analog (current sink input) and 12-bit digital (PWM) dimming control. > The LED1202 implements 12 low-side current generators with independent dimming control. > Internal volatile memory allows the user to store up to 8 different patterns, each > pattern is a particular output configuration in terms of PWM duty-cycle (on 4096 steps). > Analog dimming (on 256 steps) is per channel but common to all patterns. > +static ssize_t st1202_duration_pattern_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct st1202_chip *chip; > + struct dev_ext_attribute *eattr; > + struct st1202_led_pattern_map *map; New sysfs files need documentation. Plus, this probably should use this interface, not custom one: Documentation/ABI/testing/sysfs-class-led-trigger-pattern:What: /sys/class/leds/<led>/hw_pattern It might be better to submit driver without pattern support, then re-add it when driver is merged. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature