On 20.06.2024 11:09, Lee Jones wrote: > On Thu, 13 Jun 2024, Lee Jones wrote: > >> If both set_brightness functions return -ENOTSUPP, then the LED doesn't >> support setting a fixed brightness value, and the error message isn't >> helpful. This can be the case e.g. for LEDs supporting a specific hw >> trigger only. >> >> Pinched the subject line and commit message from Heiner: >> Link: https://lore.kernel.org/all/44177e37-9512-4044-8991-bb23b184bf37@xxxxxxxxx/ >> >> Reworked the function to provide Heiner's required semantics whilst >> simultaneously increasing readability and flow. >> >> Cc: Pavel Machek <pavel@xxxxxx> >> Cc: linux-leds@xxxxxxxxxxxxxxx >> Suggested-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> > > Heiner, you good with this solution? > > A Tested-by or Reviewed-by would be good if you have the time. > >> Signed-off-by: Lee Jones <lee@xxxxxxxxxx> Reviewed-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
