Re: [PATCH] leds: cros_ec: Implement review comments from Lee

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 20 Jun 2024, Thomas Weißschuh wrote:

> On 2024-06-20 13:27:41+0000, Lee Jones wrote:
> > On Thu, 20 Jun 2024, Thomas Weißschuh wrote:
> > 
> > > Hi Lee,
> > > 
> > > On 2024-06-20 10:31:14+0000, Lee Jones wrote:
> > > > Definitely not seen a commit message like that before
> > > 
> > > I assumed that this patch would be squashed into the original commit.
> > > 
> > > My question in which form you wanted the changes should have included
> > > "incremental series".
> > 
> > Incremental means on top.
> > 
> > A lot of maintainers don't support history re-writes, but I've reserved
> > that right since forever, so I can squash it if you like.
> 
> If it is already visible somewhere and a squash would inconvenience
> anybody I'll resend it.
> But if not I'd be happy about a squash.
> 
> (I couldn't and still can't find the public tree where driver is in)

Odd, neither can I!  Okay applied the whole set again, squashed the
patch and submitted for testing.

-- 
Lee Jones [李琼斯]




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux