On Mon, May 06, 2024 at 06:51:43PM +0200, Frank Wunderlich wrote: > > Gesendet: Montag, 06. Mai 2024 um 10:18 Uhr > > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx> > > On 05/05/2024 18:45, Frank Wunderlich wrote: > > > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > > > > > > Add missing properties already used in mt7986a.dtsi. > > > > Missing for what? Or why? Provide context, IOW, explain why they are > > missing. > > ethernet-node in mt7986a.dtsi hast reset-cells-property > > https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L559 > > and > > address-cells and size-cells are used here: > > https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L495 > > i saw the warnings while checking my r3mini dts... > > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: syscon@15000000: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/clock/mediatek,ethsys.yaml# > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: ethernet@15100000: Unevaluated properties are not allowed ('#reset-cells' was unexpected) > from schema $id: http://devicetree.org/schemas/net/mediatek,net.yaml# > > so i thought it is a good idea to fix this now ;) The dts is already fixed dropping these properties in linux-next. If you don't have child nodes with reg/ranges, then you never need #address-cells or #size-cells. Rob
