Re: [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 29/04/2024 à 10:13, AngeloGioacchino Del Regno a écrit :
Il 28/04/24 20:27, Christophe JAILLET ha scritto:
In "struct mt6370_priv", the 'reg_cfgs' field is unused.

Moreover the "struct reg_cfg" is defined nowhere. Neither in this file, nor
in a global .h file, so it is completely pointless.

Remove it.

Sure


Found with cppcheck, unusedStructMember.

So, remove it.

Again?! :-P

Yes. This way we safe twice the memory space :).



Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>


Anyway, this commit misses a Fixes tag; please add the relevant one, after which,

Will do, but this patch does not fix anything.
It is just a clean-up.

CJ


Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux