On Sun, Mar 24, 2024 at 5:02 PM Kate Hsuan <hpa@xxxxxxxxxx> wrote:
>
> There is a KTD2026 LED controller to manage the indicator LED for Xiaomi
> pad2. The ACPI for it is not properly made so the kernel can't get
> a correct description of it.
>
> This work add a description for this RGB LED controller and also set a
adds
sets
> trigger to indicate the chaging event (bq27520-0-charging). When it is
charging
> charging, the indicator LED will be turn on.
turned
...
> +/* main fwnode for ktd2026 */
> +static const struct software_node ktd2026_node = {
> + .name = "ktd2026"
Leave a comma, this is not a terminator.
> +};
When I asked about the name I relied on the fact that you have an idea
how it works. So, assuming my understanding is correct, this platform
may not have more than a single LED of this type. Dunno if we need a
comment about this.
...
> +static int __init xiaomi_mipad2_init(void)
> +{
> + return software_node_register_node_group(ktd2026_node_group);
> +}
> +
> +static void xiaomi_mipad2_exit(void)
__exit ?
> +{
> + software_node_unregister_node_group(ktd2026_node_group);
> +}
--
With Best Regards,
Andy Shevchenko
