Re: [RFC 0/2] leds: Add led_mc_set_brightness() and led_mc_trigger_event() functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On 3/9/24 20:08, Hans de Goede wrote:
Hi All,

Here is a patch-series adding led_mc_set_brightness() and
led_mc_trigger_event() functions for changing multi-color LED colors
from inside the kernel.

This is a preparation series for adding a new trigger to
drivers/power/supply/power_supply_leds.c which changes the color
of a RGB LED depending on if the battery is discharging (LED off)
charging (LED red) or full (LED green)

This is marked as RFC since the power_supply_leds.c changes have not
been written yet and as such this is compile-tested only atm.
The main goal of this RFC is to gather review feedback on the
chosen approach in these 2 patches.

Regards,

Hans


Hans de Goede (2):
   leds: core: Add led_mc_set_brightness() function
   leds: trigger: Add led_mc_trigger_event() function

  drivers/leds/led-class-multicolor.c |  1 +
  drivers/leds/led-core.c             | 31 +++++++++++++++++++++++++++++
  drivers/leds/led-triggers.c         | 20 +++++++++++++++++++
  include/linux/leds.h                | 26 ++++++++++++++++++++++++
  4 files changed, 78 insertions(+)


LGTM.

Reviewed-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>

--
Best regards,
Jacek Anaszewski




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux