On Thu, Mar 14, 2024 at 10:19 PM George Stark <gnstark@xxxxxxxxxxxxxxxxx> wrote: > > Using of devm API leads to a certain order of releasing resources. > So all dependent resources which are not devm-wrapped should be deleted > with respect to devm-release order. Mutex is one of such objects that > often is bound to other resources and has no own devm wrapping. > Since mutex_destroy() actually does nothing in non-debug builds > frequently calling mutex_destroy() is just ignored which is safe for now > but wrong formally and can lead to a problem if mutex_destroy() will be > extended so introduce devm_mutex_init(). ... > /*** Unrelated to your patch, but there are too many asterisks :-) > * mutex_destroy - mark a mutex unusable > * @lock: the mutex to be destroyed -- With Best Regards, Andy Shevchenko
