Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> writes:
> The Allied Telesis x530 products have a 7-segment LED display which is
> used for node identification when the devices are stacked. Represent
> this as a gpio-7-segment device.
>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
Acked-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
Normally, this patch should be taken in mvebu and then merged by
arm-soc. However, I haven't seen any other patch touching this file (so
no risk of merge conflict) and I think it's too late for me to make a
new pull request to arm-soc. So I'm not against it being taken with the
rest of the patches. However, I think it would be a good idea to see
what Arnd thinks about it.
Gregory
> ---
>
> Notes:
> Changes in v5:
> - group GPIO specifiers
> Changes in v4:
> - Use correct compatible name in commit message
> Changes in v3:
> - Use compatible = "gpio-7-segment" as suggested by Rob
> Changes in v2:
> - Use compatible = "generic-gpio-7seg" to keep checkpatch.pl happy
>
> arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> index 5a9ab8410b7b..2fb7304039be 100644
> --- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> +++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> @@ -43,6 +43,17 @@ uart0: serial@12000 {
> };
> };
> };
> +
> + led-7seg {
> + compatible = "gpio-7-segment";
> + segment-gpios = <&led_7seg_gpio 0 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 1 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 2 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 3 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 4 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 5 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 6 GPIO_ACTIVE_LOW>;
> + };
> };
>
> &pciec {
> @@ -149,7 +160,7 @@ i2c@3 {
> #size-cells = <0>;
> reg = <3>;
>
> - gpio@20 {
> + led_7seg_gpio: gpio@20 {
> compatible = "nxp,pca9554";
> gpio-controller;
> #gpio-cells = <2>;
> --
> 2.43.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
