Hi Chris,
On Tue, Mar 5, 2024 at 4:59 AM Chris Packham
<chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:
> Add a driver for a 7-segment LED display. At the moment only one
> character is supported but it should be possible to expand this to
> support more characters and/or 14-segment displays in the future.
>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> ---
>
> Notes:
> Changes in v4:
> - Fix one more usage of 7 segment
> - Move ASCII art diagram to DT binding
> - Include map_to_7segment.h for map_to_seg7()
> - Use initialiser for values in seg_led_update
Thanks for the update!
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -211,6 +211,16 @@ config ARM_CHARLCD
> line and the Linux version on the second line, but that's
> still useful.
>
> +config SEG_LED_GPIO
> + tristate "Generic 7-segment LED display"
"depends on GPIOLIB || COMPILE_TEST"?
The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
