On 2/03/24 07:18, Andy Shevchenko wrote: > I would drop this as it's available in UAPI header... > > ... > >> +#include <linux/bitmap.h> >> +#include <linux/container_of.h> >> +#include <linux/errno.h> >> +#include <linux/gpio/consumer.h> >> +#include <linux/mod_devicetable.h> >> +#include <linux/module.h> >> +#include <linux/platform_device.h> >> +#include <linux/types.h> >> +#include <linux/workqueue.h> > ...which you forgot to include here. > > ... Actually do I need to? I'm not using anything in map_to_7segment.h, that's all taken care of in the line-display code.
