On Sun, Mar 3, 2024 at 11:48 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Fri, Mar 1, 2024 at 7:24 PM Andy Shevchenko <andy@xxxxxxxxxx> wrote: > > On Fri, Mar 01, 2024 at 02:42:03PM +1300, Chris Packham wrote: > > > Use the dot on the 7-segment LED block to indicate USB access on the > > > x530. > > > > As I said, I'm not going to apply this even with Acks. > > I guess you should not apply any of the dts patches to the > auxdisplay tree anyway? I think it depends. If we got maintainers' Acks, etc, why not? If DT maintainers think otherwise, then no, we shouldn't. > > The problem here as I see it is the future decision on how DP should > > behave like. If you put this into DT, we will to support this to the end > > of the platform. > > As there exist 7-seg displays (and wirings) with and without DP, > the 7-seg driver and DT bindings should handle both cases. How to > wire/use the DP LED is up to the hardware designer / DTS writer. Right. But my personal statistics for now is: 100% has DP (out of about a dozen of different chip + LED combinations). What's yours? > I agree it's a thin boundary between hardware description and software > policy, though. Is that your main concern? I believe so. Because if we mark DP for use for something else, it makes it much harder to re-use it as dot/comma later on. -- With Best Regards, Andy Shevchenko
