On Fri, 1 Mar 2024, Kate Hsuan wrote: > This LED controller also installed on a Xiaomi pad2 and it is a x86 > platform. The original driver is based on device tree and can't be > used for this ACPI based system. This patch migrated the driver to > use fwnode to access the properties. Moreover, the fwnode API > supports device tree so this work won't effect the original > implementations. > > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx> > @@ -568,6 +574,8 @@ static int ktd202x_probe(struct i2c_client *client) > return ret; > } > > + chip->num_leds = (int) (unsigned long)i2c_get_match_data(client); Casting twice. -- i.