On 29/02/24 03:04, Rob Herring wrote: > On Wed, Feb 28, 2024 at 10:22:42AM +1300, Chris Packham wrote: >> Add bindings for a generic 7 segment LED display using GPIOs. >> >> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> >> --- >> >> Notes: >> Changes in v2: >> - Use compatible = "generic-gpio-7seg" to keep http://scanmail.trustwave.com/?c=20988&d=7b3f5fUJGtY-Kala5ZOOxaOVYt2BwN-ZLskYi3hWDQ&u=http%3a%2f%2fcheckpatch%2epl happy >> >> .../auxdisplay/generic-gpio-7seg.yaml | 40 +++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml >> >> diff --git a/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml b/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml >> new file mode 100644 >> index 000000000000..46d53ebdf413 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml >> @@ -0,0 +1,40 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://scanmail.trustwave.com/?c=20988&d=7b3f5fUJGtY-Kala5ZOOxaOVYt2BwN-ZLsYdhCQAWQ&u=http%3a%2f%2fdevicetree%2eorg%2fschemas%2fauxdisplay%2fgeneric%2cgpio-7seg%2eyaml%23 >> +$schema: http://scanmail.trustwave.com/?c=20988&d=7b3f5fUJGtY-Kala5ZOOxaOVYt2BwN-ZLsYY0X9WDg&u=http%3a%2f%2fdevicetree%2eorg%2fmeta-schemas%2fcore%2eyaml%23 >> + >> +title: GPIO based LED segment display >> + >> +maintainers: >> + - Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> >> + >> +properties: >> + compatible: >> + const: generic-gpio-7seg > 'generic' doesn't add anything of value. 7seg is kind of vague. So, > gpio-7-segment? Ack. >> + >> + segment-gpios: >> + description: >> + An array of GPIOs one per segment. >> + minItems: 7 > How does one know which GPIO is which segment? I've expanded the description in v3. + An array of GPIOs one per segment. The first GPIO corresponds to the A + segment the last GPIO corresponds to the G segment. Do you think that's sufficient or do I need to add more? In the driver itself I've put a little ascii art diagram of the segments.
