On Thu, 22 Feb 2024, Jernej Škrabec wrote: > Dne torek, 06. februar 2024 ob 19:13:20 CET je Aren Moynihan napisal(a): > > The status function is described in the documentation as being a rgb led > > used for system notifications on phones[1][2]. This is exactly what this > > led is used for on the PinePhone, so using status is probably more > > accurate than indicator. > > > > 1: Documentation/leds/well-known-leds.txt > > 2: include/dt-bindings/leds/common.h > > > > Signed-off-by: Aren Moynihan <aren@xxxxxxxxxxxxxxxxx> > > Sorry for late review. > > Please update subject in patches 2-3. Instead of "sun50i-a64-pinephone:" > use "allwinner: pinephone:" (check commit history of sun50i-a64-pinephone.dtsi). > Also rgb -> RGB, led -> LED. Last, please reword commit message to exclude > links and just say DT bindings documentation. > > Note that I'll merge patches 2-3 once patch 1 is merged. Works for me - I'll go apply it now. -- Lee Jones [李琼斯]
