On Tue, Feb 13, 2024 at 10:18:39AM +0100, Pavel Machek wrote: Hi Pavel, > > +What: /sys/class/leds/<led>/dim_step > > You are reinventing hardware_pattern trigger. NAK. > > I suggest you add basic support first, then look at hardware pattern > trigger and add that support in separate patch. > This makes a lot of sense and simplifies the driver. I'd like to add the hardware pattern as part of this patch as it is already implemented previously but I needed to do some clean up :) Thanks, Abdel
