Re: (subset) [PATCH] leds: trigger: stop exporting trigger_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08.02.2024 11:45, Lee Jones wrote:
> On Thu, 08 Feb 2024, Heiner Kallweit wrote:
> 
>> On 08.02.2024 11:23, Lee Jones wrote:
>>> On Thu, 08 Feb 2024, Lee Jones wrote:
>>>
>>>> On Wed, 31 Jan 2024 15:30:53 +0100, Heiner Kallweit wrote:
>>>>> 682e98564ffb ("leds: trigger: panic: Simplify led_trigger_set_panic")
>>>>> removed the last external user of variable trigger_list. So stop
>>>>> exporting it.
>>>>> If in future a need should arise again to access this variable, I think
>>>>> we better add some accessor instead of exporting the variable directly.
>>>>>
>>>>>
>>>>> [...]
>>>>
>>>> Applied, thanks!
>>>>
>>>> [1/1] leds: trigger: stop exporting trigger_list
>>>>       commit: 6171582edb46889769d994cca81cf0f0fdd8c66f
>>>
>>> I fixed the chechpatch.pl error for you and changed the subject line to
>>> match the format expected by the LED subsystem.  Please correct these
>>> yourself in subsequent contributions.  Thanks.
>>>
>> Sure. What was wrong with subject line?
> 
> Descriptions after the `leds: <device>:` start with an uppercase char.
> 
> It's nitty, but consistency helps me sleep at night! :)
> 
Ah, ok. Thanks.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux