On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > On Mon, Jan 22, 2024 at 05:24:51PM +0100, Duje Mihanović wrote: > > I believe a "select" would be more appropriate here unless these backlights > > should be hidden if GPIOLIB is disabled. The catch with "select" is that > > there seems to be no way to throw in the "|| COMPILE_TEST" other GPIO- based > > backlights have and I'm not sure what to do about that. > > I think the "|| COMPILE_TEST" might just be a copy 'n paste'ism (in fact I > may even have been guilty off propagating it in reviews when checking > for inconsistencies). > > AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig > builds will always end up with GPIOLIB enabled. If we are happy to > select it then I think that is enough! In that case I guess I'll just make it select GPIOLIB. Regards, -- Duje
