>> The kfree() function was called in one case by >> the pattern_init() function during error handling >> even if the passed variable contained a null pointer. > > It's totally valid to call kfree() on a NULL pointer: > > * If @object is NULL, no operation is performed. > > Why do we care all that much? Would you dare to categorise such special function calls as redundant? Should they be skipped in more cases? See also: https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources Regards, Markus
