> > > + * @dev: PHY device which has the LED > > > + * @index: Which LED of the PHY device or -1 > > > + * @modes: bitmap of LED polarity modes > > > + * > > > + * Configure LED with all the required polarity modes in @modes > > > + * to make it correctly turn ON or OFF. > > > > index == -1 should be explained. > > > > If you are referring to the special way of setting the LED globally, > that is not a thing anymore. Rob pointed out that having the double > reference in DT is problematic and PHY driver should handle that > internally. So it sounds like you need to change > > > + * @index: Which LED of the PHY device or -1 to remove the 'or -1' Andrew