On Sat, 09 Dec 2023, Heiner Kallweit wrote:
> It doesn't make sense to register the panic notifier if creating the
> panic trigger failed.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> ---
> drivers/leds/trigger/ledtrig-panic.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c
> index 64abf2e91..72297a845 100644
> --- a/drivers/leds/trigger/ledtrig-panic.c
> +++ b/drivers/leds/trigger/ledtrig-panic.c
> @@ -64,10 +64,13 @@ static long led_panic_blink(int state)
>
> static int __init ledtrig_panic_init(void)
> {
> + led_trigger_register_simple("panic", &trigger);
> + if (!trigger)
> + return 0;
It doesn't seem correct to return 0 on a known failure.
> +
> atomic_notifier_chain_register(&panic_notifier_list,
> &led_trigger_panic_nb);
>
> - led_trigger_register_simple("panic", &trigger);
> panic_blink = led_panic_blink;
> return 0;
> }
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
