Hey Lee, On Thu, Dec 07, 2023 at 05:06:22PM +0000, Lee Jones wrote: > On Wed, 06 Dec 2023, Uwe Kleine-König wrote: > > > With pwmchip_remove() being automatically called after switching to > > devm_pwmchip_add() the remove function can be dropped completely. Yay! > > With lpg_remove() gone there is no user of the platform device's drvdata > > left, so platform_set_drvdata() can be dropped from .probe(), too. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > Note this patch was already sent out individually, find it at > > https://lore.kernel.org/linux-leds/20231126095230.683204-2-u.kleine-koenig@xxxxxxxxxxxxxx/ > > > > drivers/leds/rgb/leds-qcom-lpg.c | 12 +----------- > > 1 file changed, 1 insertion(+), 11 deletions(-) > > Acked-by: Lee Jones <lee@xxxxxxxxxx> Given that the patches #3, #4 and #5 are beneficial even without the following patches from this series, feel free to pick them up via your tree. I don't think the whole series will go in during a single development cycle anyhow. If we get so far that the patches introducing devm_pwmchip_alloc(), pwmchip_parent() and pwmchip_[gs]et_drvdata go in, and maybe the other drivers/pwm changes, we can cope for the remaining patches (#41 + #106-#115) in the next cycle. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
