On Wed, 06 Dec 2023, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Note this patch was already sent out individually, find it at > https://lore.kernel.org/linux-leds/20231124215208.616551-3-u.kleine-koenig@xxxxxxxxxxxxxx > > drivers/leds/rgb/leds-qcom-lpg.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Acked-by: Lee Jones <lee@xxxxxxxxxx> > diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c > index 54c90ee43ef8..156b73d1f4a2 100644 > --- a/drivers/leds/rgb/leds-qcom-lpg.c > +++ b/drivers/leds/rgb/leds-qcom-lpg.c > @@ -976,9 +976,14 @@ static int lpg_pattern_mc_clear(struct led_classdev *cdev) > return lpg_pattern_clear(led); > } > > +static inline struct lpg *lpg_pwm_from_chip(struct pwm_chip *chip) > +{ > + return container_of(chip, struct lpg, pwm); > +} > + > static int lpg_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm) > { > - struct lpg *lpg = container_of(chip, struct lpg, pwm); > + struct lpg *lpg = lpg_pwm_from_chip(chip); > struct lpg_channel *chan = &lpg->channels[pwm->hwpwm]; > > return chan->in_use ? -EBUSY : 0; > @@ -994,7 +999,7 @@ static int lpg_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm) > static int lpg_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > const struct pwm_state *state) > { > - struct lpg *lpg = container_of(chip, struct lpg, pwm); > + struct lpg *lpg = lpg_pwm_from_chip(chip); > struct lpg_channel *chan = &lpg->channels[pwm->hwpwm]; > int ret = 0; > > @@ -1025,7 +1030,7 @@ static int lpg_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > static int lpg_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > struct pwm_state *state) > { > - struct lpg *lpg = container_of(chip, struct lpg, pwm); > + struct lpg *lpg = lpg_pwm_from_chip(chip); > struct lpg_channel *chan = &lpg->channels[pwm->hwpwm]; > unsigned int resolution; > unsigned int pre_div; > -- > 2.42.0 > -- Lee Jones [李琼斯]
