On Tue, 28 Nov 2023 04:00:10 +0000 Daniel Golle <daniel@xxxxxxxxxxxxxx> wrote: > Add 2.5G, 5G and 10G as available speeds to the netdev LED trigger. > > Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> So what will happen when there are more speeds? Will we create a separate file for each speed? Will we have a separate sysfs file for 10, 100, 1000, 2500, 5000, 10000, 20000, 25000, 40000, 50000, 56000, 100000, 200000, 400000, 800000 ? These are all speeds from include/uapi/linux/ethtool.h. Maybe we should have reused ethtool link mode bits, or something... Also, the files should only be present if the requested speed is supported by the net device. So if 2500 mbps is not supported, there should no be link_2500. Marek
