Hello Andy
Thanks for the review.
On 12/4/23 21:11, Andy Shevchenko wrote:
On Mon, Dec 4, 2023 at 8:07 PM George Stark <gnstark@xxxxxxxxxxxxxxxxx> wrote:
Using of devm API leads to certain order of releasing resources.
So all dependent resources which are not devm-wrapped should be deleted
with respect to devm-release order. Mutex is one of such objects that
often is bound to other resources and has no own devm wrapping.
Since mutex_destroy() actually does nothing in non-debug builds
frequently calling mutex_destroy() is just ignored which is safe for now
but wrong formally and can lead to a problem if mutex_destroy() is
extended so introduce devm_mutex_init().
...
Do you need to include mutex.h?
It's already included in linux/device.h which is included in
devm-helpers. Should I include mutex.h explicitly?
...
+/**
+ * devm_mutex_init - Resource-managed mutex initialization
+ * @dev: Device which lifetime work is bound to
+ * @lock: Pointer to a mutex
+ *
+ * Initialize mutex which is automatically destroyed when driver is detached.
the driver
Have you run scripts/kernel-doc -v -Wall -none ... against this file?
I'm pretty sure it will complain.
It does with warning "No description found for return value". Fixed
+ */
--
Best regards
George
