On Mon, Dec 4, 2023 at 8:07 PM George Stark <gnstark@xxxxxxxxxxxxxxxxx> wrote:
>
> In this driver LEDs are registered using devm_led_classdev_register()
> so they are automatically unregistered after module's remove() is done.
> led_classdev_unregister() calls module's led_set_brightness() to turn off
> the LEDs and that callback uses resources which were destroyed already
> in module's remove() so use devm API instead of remove().
...
> +static void aw2013_chip_disable_action(void *data)
> +{
> + struct aw2013 *chip = (struct aw2013 *)data;
> +
> + aw2013_chip_disable(chip);
> +}
As with mutex release, this also can be oneliner
static void aw2013_chip_disable_action(void *chip)
{
aw2013_chip_disable(chip);
}
...
> + if (devm_mutex_init(&client->dev, &chip->mutex))
> + return -ENOMEM;
Shouldn be
ret = devm_mutex_init(&client->dev, &chip->mutex);
if (ret)
return ret;
?
> + return -ENOMEM;
--
With Best Regards,
Andy Shevchenko
